[example] Group all examples under one project #525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsto
added
kind/enhancement
|
Closing this as this increases the build time during CI from ~8 min to ~20 min |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the examples are now under one Swift project (one
Package.swiftfile)Motivation:
Building all the examples on my laptop took > 1h because each example downloaded and compiled the Lambda Runtime and its dependency (NIO)
Modifications:
I remove each individual example's Package.swift and consolidated all the targets into a single file.
I adjusted the README for each example (instruct user to use
swift build --target xxxinsead ofswift build, and the same for theswift runandswift package archive commandsI adjusted the CI script
Result:
Examples build in 4 minutes on my laptop instead of ~60 min